chore: rustc 1.76.0 - Githubissues

nkysg commented 4 months ago

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

Summary by CodeRabbit

New Features
- Updated Rust toolchain to version 1.76.0, providing access to the latest enhancements and bug fixes.
Bug Fixes
- Specified dependency version for rustc-serialize to 0.3.25, ensuring consistent behavior and avoiding potential breaking changes.
Chores
- Updated linting directive to broaden the allowance for conditional blocks, enhancing code quality and reducing lint warnings.

coderabbitai[bot] commented 4 months ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
* `Cargo.lock` is excluded by `!**/*.lock`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update includes a specific version change for the rustc-serialize dependency in the Cargo.toml file and an adjustment to Clippy linting directives in the generic_proto.rs file, broadening the allowance for blocks in conditions. Additionally, the Rust toolchain is upgraded from version 1.75.0 to 1.76.0, incorporating potential improvements and new features from the latest release. Overall, these changes enhance dependency management and code quality.

Changes

Files	Change Summary
`Cargo.toml`, `rust-toolchain.toml`	Updated `rustc-serialize` dependency from `^0.3` to `0.3.25` and changed Rust toolchain channel from `1.75.0` to `1.76.0`.
`network-p2p/src/protocol/generic_proto.rs`	Modified Clippy lint directive from `#[allow(clippy::blocks_in_if_conditions)]` to `#[allow(clippy::blocks_in_conditions)]`, broadening lint allowance.

Poem

🐰 In code we hop, with joy we cheer,
New versions bloom, the path is clear.
Lints are eased, dependencies tight,
Rust shines brighter, oh what a sight!
With every change, we leap and bound,
In this code garden, new wonders are found! ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 4 months ago

Benchmark for 37e35b0

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 784.8±90.54µs | 851.0±179.62µs | +8.44% | | block_apply/block_apply_10 | 384.7±24.03ms | 376.0±16.30ms | -2.26% | | block_apply/block_apply_1000 | 40.5±1.47s | **39.3±1.38s** | **-2.96%** | | get_with_proof/db_store | 47.0±4.71µs | 48.5±5.01µs | +3.19% | | get_with_proof/mem_store | 37.5±1.59µs | 37.9±3.79µs | +1.07% | | put_and_commit/db_store/1 | 126.2±15.57µs | 118.0±8.82µs | -6.50% | | put_and_commit/db_store/10 | 1050.0±29.65µs | 1053.0±71.07µs | +0.29% | | put_and_commit/db_store/100 | **9.6±0.43ms** | 10.1±1.26ms | **+5.21%** | | put_and_commit/db_store/5 | 586.1±93.42µs | 577.3±72.94µs | -1.50% | | put_and_commit/db_store/50 | 5.2±0.65ms | 5.3±0.71ms | +1.92% | | put_and_commit/mem_store/1 | 71.8±6.39µs | 74.4±10.43µs | +3.62% | | put_and_commit/mem_store/10 | 724.2±121.57µs | 694.4±62.51µs | -4.11% | | put_and_commit/mem_store/100 | 6.7±0.72ms | 7.0±1.28ms | +4.48% | | put_and_commit/mem_store/5 | 346.5±36.02µs | 333.8±23.84µs | -3.67% | | put_and_commit/mem_store/50 | 3.3±0.25ms | 3.5±0.51ms | +6.06% | | query_block/query_block_in(10)_times(100) | 5.0±0.37ms | **4.6±0.16ms** | **-8.00%** | | query_block/query_block_in(10)_times(1000) | 45.9±1.19ms | 45.4±2.46ms | -1.09% | | query_block/query_block_in(10)_times(10000) | 471.8±19.03ms | **449.2±6.04ms** | **-4.79%** | | query_block/query_block_in(1000)_times(100) | 1177.7±25.01µs | 1194.2±75.09µs | +1.40% | | query_block/query_block_in(1000)_times(1000) | 11.9±0.50ms | **11.4±0.13ms** | **-4.20%** | | query_block/query_block_in(1000)_times(10000) | **115.2±1.13ms** | 122.4±10.24ms | **+6.25%** | | storage_transaction | 1121.7±487.61µs | 968.3±333.31µs | -13.68% | | vm/transaction_execution/1 | **411.2±14.70ms** | 452.4±34.28ms | **+10.02%** | | vm/transaction_execution/10 | 140.7±9.51ms | 147.8±7.98ms | +5.05% | | vm/transaction_execution/20 | 134.4±11.95ms | 130.6±10.30ms | -2.83% | | vm/transaction_execution/5 | **162.5±8.73ms** | 174.1±21.76ms | **+7.14%** | | vm/transaction_execution/50 | **140.3±7.31ms** | 158.5±15.97ms | **+12.97%** |