search

starcoinorg / starcoin

Starcoin - A Move smart contract blockchain network that scales by layering
Apache License 2.0
1.38k stars 289 forks source link

chore: rename starcoin-gas to starcoin-gas-meter #4187

Closed nkysg closed 3 months ago

nkysg commented 3 months ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes involve renaming the module starcoin-gas to starcoin-gas-meter across various files in the Starcoin project. This includes updates to dependencies, import statements, and package names in the Cargo.toml files, reflecting a rebranding or shift in focus for the gas management components. The overall structure and functionality of the project remain unchanged, with the modifications primarily being nominal.

Changes

Files Change Summary
Cargo.toml, config/Cargo.toml, vm/e2e-tests/Cargo.toml, vm/vm-runtime/Cargo.toml, vm/starcoin-gas-meter/Cargo.toml Renamed starcoin-gas to starcoin-gas-meter in dependency declarations and package names.
config/src/genesis_config.rs, vm/e2e-tests/src/executor.rs, vm/vm-runtime/src/move_vm_ext/vm.rs, vm/vm-runtime/src/natives.rs, vm/vm-runtime/src/starcoin_vm.rs Updated import statements from starcoin_gas to starcoin_gas_meter for gas parameters.
vm/gas-algebra-ext/src/lib.rs Added a comment indicating the need for refactoring related to starcoin-gas-schedule.

Poem

🐇 In fields of code where changes bloom,
The gas meter's name dispels the gloom.
From starcoin-gas to meter it flies,
A leap of clarity beneath the skies.
With hops of joy, we celebrate this feat,
For every change makes our project sweet! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 months ago

Benchmark for 22b6cd8

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | **762.8±74.20µs** | 930.8±240.00µs | **+22.02%** | | block_apply/block_apply_10 | 382.8±8.74ms | 377.8±10.53ms | -1.31% | | block_apply/block_apply_1000 | **39.4±1.53s** | 39.9±0.64s | **+1.27%** | | get_with_proof/db_store | 46.1±2.12µs | 45.6±1.24µs | -1.08% | | get_with_proof/mem_store | 37.1±1.63µs | 37.1±0.59µs | 0.00% | | put_and_commit/db_store/1 | 125.3±11.33µs | 119.6±10.17µs | -4.55% | | put_and_commit/db_store/10 | 1098.4±50.93µs | **1018.5±53.42µs** | **-7.27%** | | put_and_commit/db_store/100 | 10.1±0.77ms | 10.0±0.39ms | -0.99% | | put_and_commit/db_store/5 | 535.5±25.84µs | 535.9±26.93µs | +0.07% | | put_and_commit/db_store/50 | 5.1±0.64ms | 4.9±0.36ms | -3.92% | | put_and_commit/mem_store/1 | 71.6±6.22µs | 73.7±7.11µs | +2.93% | | put_and_commit/mem_store/10 | 673.8±48.06µs | 689.0±62.63µs | +2.26% | | put_and_commit/mem_store/100 | 6.7±0.48ms | 6.9±0.74ms | +2.99% | | put_and_commit/mem_store/5 | 347.0±28.29µs | 341.5±28.20µs | -1.59% | | put_and_commit/mem_store/50 | 3.3±0.17ms | 3.3±0.20ms | 0.00% | | query_block/query_block_in(10)_times(100) | 8.6±0.38ms | 8.7±0.37ms | +1.16% | | query_block/query_block_in(10)_times(1000) | 87.9±2.89ms | 86.1±2.92ms | -2.05% | | query_block/query_block_in(10)_times(10000) | 908.9±51.35ms | **884.6±22.64ms** | **-2.67%** | | query_block/query_block_in(1000)_times(100) | 1805.4±91.32µs | 1786.5±26.88µs | -1.05% | | query_block/query_block_in(1000)_times(1000) | 18.6±2.15ms | 18.3±0.80ms | -1.61% | | query_block/query_block_in(1000)_times(10000) | 192.0±26.67ms | **183.0±4.72ms** | **-4.69%** | | storage_transaction | 953.3±391.55µs | 1148.5±479.24µs | +20.48% | | vm/transaction_execution/1 | 436.8±38.16ms | 445.5±31.94ms | +1.99% | | vm/transaction_execution/10 | 138.7±8.45ms | 134.1±7.11ms | -3.32% | | vm/transaction_execution/20 | 125.9±7.89ms | 131.6±16.33ms | +4.53% | | vm/transaction_execution/5 | 167.2±12.43ms | 174.2±16.97ms | +4.19% | | vm/transaction_execution/50 | 137.8±4.77ms | 141.7±4.73ms | +2.83% |