search

starcoinorg / starcoin

Starcoin - A Move smart contract blockchain network that scales by layering
Apache License 2.0
1.38k stars 289 forks source link

Set the pruning height to 3500000 #4253

Closed jackzhhuang closed 3 weeks ago

jackzhhuang commented 3 weeks ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes involve a modification to the get_pruning_height method in the BlockChain implementation located in chain/src/chain.rs. The return value for the vega chain type has been adjusted from 4000000 to 3500000. This change specifically targets the pruning height for the vega chain without impacting other chain types or the method's overall structure.

Changes

File Change Summary
chain/src/chain.rs Updated get_pruning_height method to change return value for vega chain from 4000000 to 3500000.

Suggested reviewers

Poem

In the blockchain’s dance so bright,
The pruning height took flight,
From four to three and fifty grand,
A tweak to help our data stand.
Hoppy changes, swift and neat,
For vega now, it’s quite the feat! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 weeks ago

Benchmark for e135333

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 817.6±117.62µs | 808.4±113.80µs | -1.13% | | block_apply/block_apply_10 | 387.8±26.66ms | 372.0±17.55ms | -4.07% | | block_apply/block_apply_1000 | 45.6±2.30s | **43.6±2.03s** | **-4.39%** | | get_with_proof/db_store | 45.3±5.91µs | 46.6±4.97µs | +2.87% | | get_with_proof/mem_store | 38.9±4.91µs | **35.9±1.06µs** | **-7.71%** | | put_and_commit/db_store/1 | 121.4±14.23µs | 130.0±13.68µs | +7.08% | | put_and_commit/db_store/10 | 1247.1±277.40µs | **1079.6±119.91µs** | **-13.43%** | | put_and_commit/db_store/100 | **9.8±0.94ms** | 10.8±1.09ms | **+10.20%** | | put_and_commit/db_store/5 | 637.3±92.98µs | 656.1±95.24µs | +2.95% | | put_and_commit/db_store/50 | 5.3±0.50ms | 5.1±0.47ms | -3.77% | | put_and_commit/mem_store/1 | 69.8±7.04µs | 72.8±9.60µs | +4.30% | | put_and_commit/mem_store/10 | 759.3±141.04µs | **656.3±68.20µs** | **-13.57%** | | put_and_commit/mem_store/100 | 6.5±0.52ms | 7.0±0.86ms | +7.69% | | put_and_commit/mem_store/5 | 341.8±72.40µs | 372.8±69.45µs | +9.07% | | put_and_commit/mem_store/50 | 3.5±0.42ms | 3.5±0.49ms | 0.00% | | query_block/query_block_in(10)_times(100) | 8.8±1.25ms | 8.8±0.69ms | 0.00% | | query_block/query_block_in(10)_times(1000) | **85.8±4.61ms** | 94.3±16.45ms | **+9.91%** | | query_block/query_block_in(10)_times(10000) | 920.1±115.51ms | 887.5±58.69ms | -3.54% | | query_block/query_block_in(1000)_times(100) | 1339.7±67.58µs | 1305.4±80.26µs | -2.56% | | query_block/query_block_in(1000)_times(1000) | 14.2±1.13ms | **12.9±0.74ms** | **-9.15%** | | query_block/query_block_in(1000)_times(10000) | 132.3±7.74ms | **127.1±3.68ms** | **-3.93%** | | storage_transaction | 1094.2±440.33µs | 1086.6±391.36µs | -0.69% | | vm/transaction_execution/1 | 437.6±29.77ms | 450.7±34.59ms | +2.99% | | vm/transaction_execution/10 | 142.0±8.32ms | **132.4±7.33ms** | **-6.76%** | | vm/transaction_execution/20 | 133.4±9.29ms | **124.7±6.33ms** | **-6.52%** | | vm/transaction_execution/5 | 179.6±20.59ms | 179.7±19.07ms | +0.06% | | vm/transaction_execution/50 | 153.6±10.82ms | 143.2±15.81ms | -6.77% |