Fix bug: no store the sync dag block

[jackzhhuang]

Pull request type

Please check the type of change your PR introduces:

• [ ] Bugfix
• [ ] Feature
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] Documentation content changes
• [ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced management of DAG sync blocks during synchronization.
  • New test cases added for BlockDAG functionality, improving test coverage and robustness.

• Bug Fixes

  • Updated container startup command to include removal of the sync directory, ensuring a cleaner environment.

• Documentation

  • Added comments and documentation clarifying method behaviors in the GHOSTDAG protocol.

• Chores

  • Introduced additional debug logging in the pruning point management process for better traceability.
  • Improved logging clarity in the BlockDAG calculations for enhanced debugging.

[coderabbitai[bot]]

Walkthrough

The pull request introduces several modifications across multiple files. Key changes include the addition of a line to delete all DAG sync blocks in the ensure_dag_parent_blocks_exist method of the BlockCollector struct, and updates to the fetch_blocks method to improve block management. Additionally, the starcoin StatefulSet configuration is adjusted to remove the sync directory during startup. The GhostdagManager struct sees a method rename and changes to error handling, while the PruningPointManagerT struct receives enhanced debug logging in the next_pruning_point method.

Changes

File Path	Change Summary
sync/src/tasks/block_sync_task.rs	- Modified ensure_dag_parent_blocks_exist to delete all DAG sync blocks under certain conditions. - Updated fetch_blocks to ensure blocks fetched from local store are saved to sync_dag_store.
kube/manifest/starcoin-vega.yaml	- Updated container args to include removal of the sync directory during startup.
flexidag/src/ghostdag/protocol.rs	- Renamed _verify_and_ghostdata method and altered its error handling logic. - Removed bail from imports.
flexidag/src/prune/pruning_point_manager.rs	- Added debug logging in next_pruning_point to output key parameter values for better traceability.
flexidag/src/blockdag.rs	- Enhanced logging in calc_mergeset_and_tips to clarify details about next_ghostdata.
flexidag/tests/tests.rs	- Added add_and_print_with_difficulty function for block creation with specified difficulty. - Modified add_and_print_with_pruning_point to standardize difficulty. - Introduced test_verification_blue_block_inconsistent and expanded existing tests for better coverage.

Possibly related PRs

• #4153: This PR enhances the BlockCollector struct in block_sync_task.rs, which is directly related to the changes made in the main PR that also modifies the BlockCollector struct's methods for managing DAG sync blocks.
• #4165: This PR introduces a new method delete_all_dag_sync_block in sync_dag_store.rs, which aligns with the main PR's addition of a line to delete all DAG sync blocks from the sync_dag_store.
• #4199: This PR modifies the logic in block_sync_task.rs to streamline how absent blocks are processed, which is relevant to the main PR's focus on improving block management during synchronization.
• #4248: This PR updates the find_absent_ancestor method in block_sync_task.rs, which is directly related to the changes in the main PR that also involves modifications to methods within the same file.

Suggested reviewers

• sanlee42
• nkysg
• yourmoonlight

🐇 In the code we hop and play,
Deleting blocks along the way.
With logs so clear, we trace our path,
In sync we dance, avoiding wrath.
A change here, a tweak there,
Together we build, with utmost care! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[github-actions[bot]]

Benchmark for 9f9cda4

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 771.2±78.56µs | 812.6±135.63µs | +5.37% | | block_apply/block_apply_10 | 384.3±14.16ms | **362.5±7.78ms** | **-5.67%** | | block_apply/block_apply_1000 | 43.0±1.73s | **42.8±2.47s** | **-0.47%** | | get_with_proof/db_store | 44.9±7.02µs | 43.5±3.38µs | -3.12% | | get_with_proof/mem_store | 36.8±4.12µs | **35.2±1.53µs** | **-4.35%** | | put_and_commit/db_store/1 | 123.5±16.10µs | 139.1±23.30µs | +12.63% | | put_and_commit/db_store/10 | **1006.3±47.14µs** | 1237.6±284.16µs | **+22.99%** | | put_and_commit/db_store/100 | 10.0±0.57ms | 9.7±0.46ms | -3.00% | | put_and_commit/db_store/5 | 541.6±41.27µs | 554.2±45.44µs | +2.33% | | put_and_commit/db_store/50 | 5.0±0.25ms | 5.0±0.29ms | 0.00% | | put_and_commit/mem_store/1 | 74.5±9.69µs | 71.2±7.97µs | -4.43% | | put_and_commit/mem_store/10 | 660.8±72.31µs | 719.2±131.51µs | +8.84% | | put_and_commit/mem_store/100 | 6.6±0.58ms | 6.6±0.73ms | 0.00% | | put_and_commit/mem_store/5 | 498.4±106.72µs | **368.0±65.08µs** | **-26.16%** | | put_and_commit/mem_store/50 | 3.5±0.53ms | 3.3±0.31ms | -5.71% | | query_block/query_block_in(10)_times(100) | **8.5±0.48ms** | 9.5±0.86ms | **+11.76%** | | query_block/query_block_in(10)_times(1000) | 84.6±4.35ms | 87.3±9.12ms | +3.19% | | query_block/query_block_in(10)_times(10000) | **817.8±28.50ms** | 862.0±48.80ms | **+5.40%** | | query_block/query_block_in(1000)_times(100) | **1198.0±70.32µs** | 1275.4±76.09µs | **+6.46%** | | query_block/query_block_in(1000)_times(1000) | 12.7±0.97ms | **12.0±0.31ms** | **-5.51%** | | query_block/query_block_in(1000)_times(10000) | 135.4±7.51ms | **123.6±5.51ms** | **-8.71%** | | storage_transaction | 1181.6±457.20µs | 1014.8±366.48µs | -14.12% | | vm/transaction_execution/1 | 413.2±29.83ms | 412.3±9.98ms | -0.22% | | vm/transaction_execution/10 | 132.3±10.79ms | 139.0±14.66ms | +5.06% | | vm/transaction_execution/20 | 133.5±8.85ms | **119.8±6.03ms** | **-10.26%** | | vm/transaction_execution/5 | 176.0±18.32ms | **165.7±8.61ms** | **-5.85%** | | vm/transaction_execution/50 | 157.2±12.25ms | **141.7±6.37ms** | **-9.86%** |

[github-actions[bot]]

Benchmark for 0d17403

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 802.6±125.80µs | 825.5±108.35µs | +2.85% | | block_apply/block_apply_10 | **378.4±20.63ms** | 495.5±32.93ms | **+30.95%** | | block_apply/block_apply_1000 | 46.4±2.67s | **44.0±2.47s** | **-5.17%** | | get_with_proof/db_store | 50.8±8.94µs | 56.7±14.49µs | +11.61% | | get_with_proof/mem_store | 39.2±4.97µs | 39.3±4.60µs | +0.26% | | put_and_commit/db_store/1 | 150.3±27.01µs | **116.7±8.92µs** | **-22.36%** | | put_and_commit/db_store/10 | 1152.1±134.09µs | 1197.2±153.15µs | +3.91% | | put_and_commit/db_store/100 | 11.3±1.89ms | 11.3±1.33ms | 0.00% | | put_and_commit/db_store/5 | 579.9±85.85µs | 558.6±53.95µs | -3.67% | | put_and_commit/db_store/50 | 5.9±1.05ms | 6.0±0.91ms | +1.69% | | put_and_commit/mem_store/1 | 80.5±16.91µs | 75.2±10.40µs | -6.58% | | put_and_commit/mem_store/10 | 664.6±92.98µs | 748.4±116.85µs | +12.61% | | put_and_commit/mem_store/100 | 7.0±0.76ms | 7.2±1.20ms | +2.86% | | put_and_commit/mem_store/5 | 453.8±83.25µs | **337.8±43.92µs** | **-25.56%** | | put_and_commit/mem_store/50 | 4.0±0.66ms | 3.7±0.69ms | -7.50% | | query_block/query_block_in(10)_times(100) | 9.2±0.82ms | 9.0±1.55ms | -2.17% | | query_block/query_block_in(10)_times(1000) | **100.6±11.64ms** | 133.2±17.13ms | **+32.41%** | | query_block/query_block_in(10)_times(10000) | 962.7±132.66ms | 902.5±65.17ms | -6.25% | | query_block/query_block_in(1000)_times(100) | 1585.8±315.02µs | 1522.8±186.30µs | -3.97% | | query_block/query_block_in(1000)_times(1000) | **14.2±1.14ms** | 15.5±1.23ms | **+9.15%** | | query_block/query_block_in(1000)_times(10000) | 158.0±15.58ms | 151.0±20.18ms | -4.43% | | storage_transaction | 1169.8±493.61µs | 1448.6±647.68µs | +23.83% | | vm/transaction_execution/1 | **409.3±22.74ms** | 455.3±53.85ms | **+11.24%** | | vm/transaction_execution/10 | **130.8±6.29ms** | 156.3±15.04ms | **+19.50%** | | vm/transaction_execution/20 | 128.5±9.96ms | 135.7±14.78ms | +5.60% | | vm/transaction_execution/5 | 167.1±14.28ms | 175.1±10.11ms | +4.79% | | vm/transaction_execution/50 | **146.1±6.81ms** | 158.0±14.88ms | **+8.15%** |

[github-actions[bot]]

Benchmark for 5c1818c

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 878.5±157.92µs | 845.2±138.59µs | -3.79% | | block_apply/block_apply_10 | 422.9±38.41ms | 445.8±55.12ms | +5.41% | | block_apply/block_apply_1000 | 44.7±2.10s | **43.7±1.76s** | **-2.24%** | | get_with_proof/db_store | **47.8±7.53µs** | 62.0±12.83µs | **+29.71%** | | get_with_proof/mem_store | **36.5±2.38µs** | 47.4±7.26µs | **+29.86%** | | put_and_commit/db_store/1 | **135.4±14.26µs** | 161.9±26.57µs | **+19.57%** | | put_and_commit/db_store/10 | 1332.0±275.31µs | **1162.1±119.43µs** | **-12.76%** | | put_and_commit/db_store/100 | **10.3±1.09ms** | 12.3±2.66ms | **+19.42%** | | put_and_commit/db_store/5 | 632.4±82.86µs | 660.1±105.58µs | +4.38% | | put_and_commit/db_store/50 | 7.3±2.28ms | **5.7±0.90ms** | **-21.92%** | | put_and_commit/mem_store/1 | **72.5±9.74µs** | 84.8±15.46µs | **+16.97%** | | put_and_commit/mem_store/10 | 724.7±115.58µs | 733.7±149.98µs | +1.24% | | put_and_commit/mem_store/100 | 7.2±1.43ms | 7.3±1.33ms | +1.39% | | put_and_commit/mem_store/5 | 402.2±88.67µs | 430.1±84.07µs | +6.94% | | put_and_commit/mem_store/50 | 3.4±0.40ms | 3.5±0.54ms | +2.94% | | query_block/query_block_in(10)_times(100) | 9.0±0.59ms | 9.1±0.49ms | +1.11% | | query_block/query_block_in(10)_times(1000) | 87.1±8.52ms | 91.3±7.97ms | +4.82% | | query_block/query_block_in(10)_times(10000) | **971.9±72.33ms** | 1117.2±174.09ms | **+14.95%** | | query_block/query_block_in(1000)_times(100) | **1633.0±304.66µs** | 2.3±0.35ms | **+40.85%** | | query_block/query_block_in(1000)_times(1000) | **13.7±1.69ms** | 18.5±2.69ms | **+35.04%** | | query_block/query_block_in(1000)_times(10000) | **132.8±7.82ms** | 143.7±16.16ms | **+8.21%** | | storage_transaction | 1115.3±389.06µs | 1114.8±405.68µs | -0.04% | | vm/transaction_execution/1 | 458.2±31.80ms | 465.4±53.29ms | +1.57% | | vm/transaction_execution/10 | **147.0±9.78ms** | 179.3±24.80ms | **+21.97%** | | vm/transaction_execution/20 | 150.3±10.25ms | 143.3±8.53ms | -4.66% | | vm/transaction_execution/5 | 197.7±12.41ms | **171.9±10.44ms** | **-13.05%** | | vm/transaction_execution/50 | 150.2±10.23ms | 146.5±9.62ms | -2.46% |

[github-actions[bot]]

Benchmark for 4cdd21e

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 902.3±173.52µs | 886.7±184.57µs | -1.73% | | block_apply/block_apply_10 | 410.9±21.79ms | **381.3±30.82ms** | **-7.20%** | | block_apply/block_apply_1000 | 45.4±2.46s | **44.3±1.53s** | **-2.42%** | | get_with_proof/db_store | **44.1±3.00µs** | 48.9±7.53µs | **+10.88%** | | get_with_proof/mem_store | **37.5±5.87µs** | 47.5±10.12µs | **+26.67%** | | put_and_commit/db_store/1 | 145.1±31.40µs | 162.8±26.19µs | +12.20% | | put_and_commit/db_store/10 | **1074.8±73.40µs** | 1154.2±199.19µs | **+7.39%** | | put_and_commit/db_store/100 | 11.0±2.29ms | 11.2±1.73ms | +1.82% | | put_and_commit/db_store/5 | 565.3±46.61µs | 556.4±45.06µs | -1.57% | | put_and_commit/db_store/50 | **5.3±0.34ms** | 5.7±0.81ms | **+7.55%** | | put_and_commit/mem_store/1 | 78.7±12.73µs | 75.9±10.55µs | -3.56% | | put_and_commit/mem_store/10 | 692.1±103.78µs | 701.9±76.23µs | +1.42% | | put_and_commit/mem_store/100 | **6.3±0.34ms** | 7.0±1.27ms | **+11.11%** | | put_and_commit/mem_store/5 | 340.6±43.30µs | 336.9±39.65µs | -1.09% | | put_and_commit/mem_store/50 | 3.3±0.48ms | 3.3±0.38ms | 0.00% | | query_block/query_block_in(10)_times(100) | **8.5±0.57ms** | 9.2±0.91ms | **+8.24%** | | query_block/query_block_in(10)_times(1000) | 106.1±10.06ms | **94.7±12.41ms** | **-10.74%** | | query_block/query_block_in(10)_times(10000) | 956.4±125.04ms | 950.1±73.71ms | -0.66% | | query_block/query_block_in(1000)_times(100) | 1321.5±147.15µs | 1290.1±56.38µs | -2.38% | | query_block/query_block_in(1000)_times(1000) | **13.8±1.41ms** | 15.4±3.67ms | **+11.59%** | | query_block/query_block_in(1000)_times(10000) | 128.0±8.81ms | 129.5±6.20ms | +1.17% | | storage_transaction | 1273.6±505.27µs | 1286.9±484.77µs | +1.04% | | vm/transaction_execution/1 | 419.5±26.06ms | 408.9±19.77ms | -2.53% | | vm/transaction_execution/10 | 142.9±7.35ms | 137.5±10.73ms | -3.78% | | vm/transaction_execution/20 | 145.3±33.90ms | **126.1±8.46ms** | **-13.21%** | | vm/transaction_execution/5 | 181.7±12.78ms | 172.2±25.38ms | -5.23% | | vm/transaction_execution/50 | 167.2±14.01ms | **149.9±9.51ms** | **-10.35%** |

[github-actions[bot]]

Benchmark for 97a16cb

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 840.6±143.24µs | 835.8±163.26µs | -0.57% | | block_apply/block_apply_10 | 378.9±15.68ms | 377.8±17.58ms | -0.29% | | block_apply/block_apply_1000 | 46.8±4.70s | **40.9±1.33s** | **-12.61%** | | get_with_proof/db_store | 48.0±8.04µs | 45.3±3.89µs | -5.63% | | get_with_proof/mem_store | 37.5±3.21µs | 38.7±6.44µs | +3.20% | | put_and_commit/db_store/1 | 153.2±27.71µs | **118.4±11.59µs** | **-22.72%** | | put_and_commit/db_store/10 | 1045.3±68.93µs | 1085.0±63.50µs | +3.80% | | put_and_commit/db_store/100 | 9.8±1.54ms | 10.8±1.36ms | +10.20% | | put_and_commit/db_store/5 | 604.7±108.62µs | **528.9±30.26µs** | **-12.54%** | | put_and_commit/db_store/50 | 6.5±1.42ms | **5.2±0.50ms** | **-20.00%** | | put_and_commit/mem_store/1 | 75.4±10.59µs | 73.2±11.19µs | -2.92% | | put_and_commit/mem_store/10 | 697.3±94.99µs | 679.0±90.41µs | -2.62% | | put_and_commit/mem_store/100 | 9.2±1.72ms | **7.0±1.22ms** | **-23.91%** | | put_and_commit/mem_store/5 | 378.2±93.14µs | **327.3±32.60µs** | **-13.46%** | | put_and_commit/mem_store/50 | 3.5±0.72ms | 3.3±0.51ms | -5.71% | | query_block/query_block_in(10)_times(100) | 10.8±2.07ms | 10.2±2.47ms | -5.56% | | query_block/query_block_in(10)_times(1000) | 105.5±15.44ms | **86.6±7.97ms** | **-17.91%** | | query_block/query_block_in(10)_times(10000) | 959.8±47.83ms | **828.4±31.76ms** | **-13.69%** | | query_block/query_block_in(1000)_times(100) | **1199.1±49.11µs** | 1286.8±93.64µs | **+7.31%** | | query_block/query_block_in(1000)_times(1000) | **12.3±0.57ms** | 14.7±2.08ms | **+19.51%** | | query_block/query_block_in(1000)_times(10000) | 123.6±4.32ms | 126.7±6.94ms | +2.51% | | storage_transaction | 1106.0±386.50µs | 1119.0±331.35µs | +1.18% | | vm/transaction_execution/1 | 408.5±10.26ms | 413.9±15.00ms | +1.32% | | vm/transaction_execution/10 | 144.7±10.52ms | 140.1±8.53ms | -3.18% | | vm/transaction_execution/20 | **119.2±6.23ms** | 127.2±11.57ms | **+6.71%** | | vm/transaction_execution/5 | **160.8±7.16ms** | 180.5±12.78ms | **+12.25%** | | vm/transaction_execution/50 | 150.3±9.40ms | 153.8±14.98ms | +2.33% |

[github-actions[bot]]

Benchmark for 083e3d4

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 982.2±255.32µs | 903.8±167.33µs | -7.98% | | block_apply/block_apply_10 | 411.3±23.09ms | **393.6±10.75ms** | **-4.30%** | | block_apply/block_apply_1000 | **46.6±2.79s** | 47.3±3.28s | **+1.50%** | | get_with_proof/db_store | 50.2±7.93µs | 48.0±2.31µs | -4.38% | | get_with_proof/mem_store | 38.3±4.65µs | 37.3±2.10µs | -2.61% | | put_and_commit/db_store/1 | **130.5±8.63µs** | 148.4±27.87µs | **+13.72%** | | put_and_commit/db_store/10 | 1303.2±192.85µs | 1440.0±161.83µs | +10.50% | | put_and_commit/db_store/100 | 11.1±0.97ms | 10.8±0.72ms | -2.70% | | put_and_commit/db_store/5 | 634.0±63.54µs | 649.9±76.81µs | +2.51% | | put_and_commit/db_store/50 | 5.7±0.49ms | 5.8±0.61ms | +1.75% | | put_and_commit/mem_store/1 | 76.0±8.86µs | 72.7±7.81µs | -4.34% | | put_and_commit/mem_store/10 | 678.5±53.86µs | 712.3±75.05µs | +4.98% | | put_and_commit/mem_store/100 | 8.3±1.60ms | 8.6±1.60ms | +3.61% | | put_and_commit/mem_store/5 | 374.4±79.33µs | 366.9±48.63µs | -2.00% | | put_and_commit/mem_store/50 | 3.6±0.47ms | 3.5±0.39ms | -2.78% | | query_block/query_block_in(10)_times(100) | 9.5±1.03ms | **8.3±0.48ms** | **-12.63%** | | query_block/query_block_in(10)_times(1000) | 85.6±3.91ms | 87.6±4.83ms | +2.34% | | query_block/query_block_in(10)_times(10000) | **863.6±37.25ms** | 919.0±65.69ms | **+6.42%** | | query_block/query_block_in(1000)_times(100) | 1462.7±149.63µs | **1313.2±71.40µs** | **-10.22%** | | query_block/query_block_in(1000)_times(1000) | 19.3±2.61ms | **14.0±0.89ms** | **-27.46%** | | query_block/query_block_in(1000)_times(10000) | **141.5±7.19ms** | 205.2±39.44ms | **+45.02%** | | storage_transaction | 1023.5±337.73µs | 1122.8±368.62µs | +9.70% | | vm/transaction_execution/1 | 456.8±34.85ms | 472.7±32.01ms | +3.48% | | vm/transaction_execution/10 | 154.4±16.85ms | 146.3±9.21ms | -5.25% | | vm/transaction_execution/20 | 144.2±15.27ms | **132.3±5.17ms** | **-8.25%** | | vm/transaction_execution/5 | 184.2±15.60ms | **165.7±7.36ms** | **-10.04%** | | vm/transaction_execution/50 | **161.7±14.40ms** | 182.7±41.59ms | **+12.99%** |

[github-actions[bot]]

Benchmark for 257dc8f

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | 825.3±138.74µs | 945.7±313.93µs | +14.59% | | block_apply/block_apply_10 | **410.3±20.11ms** | 484.2±65.00ms | **+18.01%** | | block_apply/block_apply_1000 | **48.0±2.00s** | 48.5±4.05s | **+1.04%** | | get_with_proof/db_store | 68.5±14.32µs | 66.5±13.28µs | -2.92% | | get_with_proof/mem_store | 40.2±4.77µs | 40.5±3.84µs | +0.75% | | put_and_commit/db_store/1 | 169.2±37.98µs | 151.8±22.43µs | -10.28% | | put_and_commit/db_store/10 | 1220.4±221.35µs | 1221.2±169.45µs | +0.07% | | put_and_commit/db_store/100 | 12.2±1.42ms | 12.1±1.42ms | -0.82% | | put_and_commit/db_store/5 | 782.2±127.32µs | **614.8±41.42µs** | **-21.40%** | | put_and_commit/db_store/50 | 6.6±1.08ms | 7.4±1.49ms | +12.12% | | put_and_commit/mem_store/1 | 76.8±9.97µs | 79.1±9.42µs | +2.99% | | put_and_commit/mem_store/10 | 706.6±81.57µs | 730.5±116.45µs | +3.38% | | put_and_commit/mem_store/100 | 7.5±1.26ms | 8.4±1.25ms | +12.00% | | put_and_commit/mem_store/5 | 388.7±66.87µs | 383.4±55.63µs | -1.36% | | put_and_commit/mem_store/50 | 4.1±0.83ms | 3.8±0.59ms | -7.32% | | query_block/query_block_in(10)_times(100) | **9.3±1.04ms** | 11.3±1.61ms | **+21.51%** | | query_block/query_block_in(10)_times(1000) | 103.1±14.61ms | 104.4±14.13ms | +1.26% | | query_block/query_block_in(10)_times(10000) | 1025.1±157.15ms | 1036.8±135.28ms | +1.14% | | query_block/query_block_in(1000)_times(100) | 1586.2±412.98µs | 1597.3±220.75µs | +0.70% | | query_block/query_block_in(1000)_times(1000) | 15.9±1.20ms | **14.6±1.43ms** | **-8.18%** | | query_block/query_block_in(1000)_times(10000) | **148.1±7.09ms** | 159.1±31.01ms | **+7.43%** | | storage_transaction | 1158.0±437.46µs | 1105.0±369.14µs | -4.58% | | vm/transaction_execution/1 | 442.7±33.41ms | 472.1±51.70ms | +6.64% | | vm/transaction_execution/10 | 139.6±7.48ms | 139.3±8.87ms | -0.21% | | vm/transaction_execution/20 | 132.1±7.09ms | 138.1±10.44ms | +4.54% | | vm/transaction_execution/5 | 173.3±14.87ms | 177.9±12.29ms | +2.65% | | vm/transaction_execution/50 | 143.5±3.36ms | 146.3±6.90ms | +1.95% |

[github-actions[bot]]

Benchmark for 2d9ad34

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | **841.1±119.43µs** | 982.7±194.43µs | **+16.84%** | | block_apply/block_apply_10 | **378.1±8.62ms** | 509.0±114.65ms | **+34.62%** | | block_apply/block_apply_1000 | **43.2±1.88s** | 48.5±2.49s | **+12.27%** | | get_with_proof/db_store | **46.1±2.60µs** | 63.8±13.68µs | **+38.39%** | | get_with_proof/mem_store | **36.7±1.26µs** | 40.2±5.37µs | **+9.54%** | | put_and_commit/db_store/1 | **148.7±23.48µs** | 177.0±34.32µs | **+19.03%** | | put_and_commit/db_store/10 | 1629.4±424.88µs | **1326.7±187.95µs** | **-18.58%** | | put_and_commit/db_store/100 | 12.3±1.99ms | 13.8±1.97ms | +12.20% | | put_and_commit/db_store/5 | 612.0±91.66µs | 615.1±67.47µs | +0.51% | | put_and_commit/db_store/50 | **5.3±0.50ms** | 6.4±1.08ms | **+20.75%** | | put_and_commit/mem_store/1 | 77.9±13.15µs | 82.9±13.52µs | +6.42% | | put_and_commit/mem_store/10 | 695.2±97.64µs | 710.2±76.67µs | +2.16% | | put_and_commit/mem_store/100 | **6.6±0.39ms** | 7.8±0.94ms | **+18.18%** | | put_and_commit/mem_store/5 | 376.1±67.30µs | 390.4±77.07µs | +3.80% | | put_and_commit/mem_store/50 | **3.6±0.47ms** | 4.1±0.74ms | **+13.89%** | | query_block/query_block_in(10)_times(100) | **8.7±0.62ms** | 12.0±3.44ms | **+37.93%** | | query_block/query_block_in(10)_times(1000) | **86.6±5.23ms** | 93.0±8.42ms | **+7.39%** | | query_block/query_block_in(10)_times(10000) | **850.2±33.29ms** | 1067.3±197.15ms | **+25.54%** | | query_block/query_block_in(1000)_times(100) | **1264.6±57.82µs** | 1605.3±273.81µs | **+26.94%** | | query_block/query_block_in(1000)_times(1000) | **12.3±0.27ms** | 15.6±1.34ms | **+26.83%** | | query_block/query_block_in(1000)_times(10000) | 145.0±22.24ms | 144.1±17.57ms | -0.62% | | storage_transaction | 1051.6±335.79µs | 1334.5±542.30µs | +26.90% | | vm/transaction_execution/1 | 477.1±60.72ms | 455.2±32.68ms | -4.59% | | vm/transaction_execution/10 | **135.4±7.27ms** | 156.3±17.11ms | **+15.44%** | | vm/transaction_execution/20 | 133.9±10.70ms | 139.2±13.96ms | +3.96% | | vm/transaction_execution/5 | 175.0±11.27ms | 179.3±8.31ms | +2.46% | | vm/transaction_execution/50 | **142.3±4.73ms** | 187.4±17.33ms | **+31.69%** |

[github-actions[bot]]

Benchmark for 20c726a

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | accumulator_append | **934.0±202.40µs** | 1184.1±298.97µs | **+26.78%** | | block_apply/block_apply_10 | 411.7±45.62ms | 438.1±46.18ms | +6.41% | | block_apply/block_apply_1000 | **47.1±2.29s** | 49.2±3.50s | **+4.46%** | | get_with_proof/db_store | **45.8±1.38µs** | 48.4±4.65µs | **+5.68%** | | get_with_proof/mem_store | **36.8±1.34µs** | 40.4±3.34µs | **+9.78%** | | put_and_commit/db_store/1 | **131.3±8.36µs** | 180.9±31.99µs | **+37.78%** | | put_and_commit/db_store/10 | 1319.7±161.17µs | 1354.4±269.34µs | +2.63% | | put_and_commit/db_store/100 | 12.2±2.11ms | 12.0±1.81ms | -1.64% | | put_and_commit/db_store/5 | 797.0±164.62µs | **632.0±65.49µs** | **-20.70%** | | put_and_commit/db_store/50 | 6.7±1.35ms | 6.8±1.07ms | +1.49% | | put_and_commit/mem_store/1 | **74.2±11.75µs** | 84.3±7.37µs | **+13.61%** | | put_and_commit/mem_store/10 | 752.8±138.40µs | 838.1±100.18µs | +11.33% | | put_and_commit/mem_store/100 | **7.6±1.04ms** | 8.9±1.64ms | **+17.11%** | | put_and_commit/mem_store/5 | 372.7±69.85µs | 343.7±43.24µs | -7.78% | | put_and_commit/mem_store/50 | 4.3±0.88ms | **3.5±0.35ms** | **-18.60%** | | query_block/query_block_in(10)_times(100) | 9.2±0.95ms | **8.7±0.35ms** | **-5.43%** | | query_block/query_block_in(10)_times(1000) | **88.7±3.65ms** | 108.6±13.19ms | **+22.44%** | | query_block/query_block_in(10)_times(10000) | 1031.0±138.63ms | 959.0±104.80ms | -6.98% | | query_block/query_block_in(1000)_times(100) | 1673.6±174.34µs | **1369.5±86.15µs** | **-18.17%** | | query_block/query_block_in(1000)_times(1000) | **12.9±0.84ms** | 18.9±3.00ms | **+46.51%** | | query_block/query_block_in(1000)_times(10000) | 140.0±12.90ms | 137.9±7.83ms | -1.50% | | storage_transaction | 1210.3±366.37µs | 1127.3±464.67µs | -6.86% | | vm/transaction_execution/1 | **415.8±11.60ms** | 473.3±37.56ms | **+13.83%** | | vm/transaction_execution/10 | 141.5±10.28ms | 143.8±12.52ms | +1.63% | | vm/transaction_execution/20 | 137.3±9.09ms | 140.1±10.65ms | +2.04% | | vm/transaction_execution/5 | 185.0±13.99ms | **174.7±7.29ms** | **-5.57%** | | vm/transaction_execution/50 | 157.2±20.04ms | 171.8±18.78ms | +9.29% |