search

stardog-union / helm-charts

Stardog Helm Charts
Apache License 2.0
9 stars 12 forks source link

PLAT-6142 - store admin PW in container environment, not on filesystem #100

Closed gregoryg closed 3 months ago

gregoryg commented 9 months ago

In response to https://stardog.atlassian.net/browse/PLAT-6142 - Security: Potential admin password leak

Bosch and other customers were concerned that the admin password was stored on the containers' file sytem.

This PR removes all file system writing / mounting of the password and stores it in an environment variable instead.

lafirey commented 3 months ago

@pdmars @scardena @ctffarley Where does this PR stand? Bosch is asking for this functionality so if it's a quick win to merge that's great.

cc @mhgrove

pdmars commented 3 months ago

@pdmars @scardena @ctffarley Where does this PR stand? Bosch is asking for this functionality so if it's a quick win to merge that's great.

cc @mhgrove

Looks like there's now a conflict to resolve, but otherwise I'm fine with it. Still would be good to get the cloud team to sign off, for awareness if nothing else.

pdmars commented 3 months ago

This PR is from a fork. I'm going to close the PR, cherry pick this commit, resolve the conflict and open a new PR.