search

stardog-union / helm-charts

Stardog Helm Charts
Apache License 2.0
9 stars 12 forks source link

[PLAT-6765] Adds cache target chart #105

Closed pdmars closed 4 months ago

pdmars commented 4 months ago

it looks great! thanks for adding the tests as well. just a little nitpick, it would be great if we can use an existing adminpw secret, something like that was done here: 98dfb0e. it's fine if we want to do that in another PR or at some other time.

great! I think I have that passwordSecretRef stuff in these charts, but let me know if you are thinking something else than what's here

scardena commented 4 months ago

it looks great! thanks for adding the tests as well. just a little nitpick, it would be great if we can use an existing adminpw secret, something like that was done here: 98dfb0e. it's fine if we want to do that in another PR or at some other time.

great! I think I have that passwordSecretRef stuff in these charts, but let me know if you are thinking something else than what's here

welp you are right! there was a specific file that through me off but apparently i can't read. thanks!