search

stardog-union / helm-charts

Stardog Helm Charts
Apache License 2.0
9 stars 12 forks source link

Apply the security context to the post install job (fixes #25) #26

Closed pdmars closed 3 years ago

pdmars commented 3 years ago

one thing that I've been doing is to also add serviceAccountName: if securityContext is enabled. I get what I am doing can be a bit misleading because defining a serviceAccount is not strictly related to securityContext, but it's related to how PSPs are being used. I wonder if I should extract out the serviceAccountName from the if block and set it to default by default. what are your thoughts on that?

Yeah that's a good point. I think we should pull out the service account and make it configurable, setting it to default in the values.yaml. Can you create an issue on this repo to do that as its own change?