standard storage class does not necessarily exist

stardog-union / helm-charts

Stardog Helm Charts

Apache License 2.0

9 stars 12 forks source link

standard storage class does not necessarily exist #74

Open fungiboletus opened 2 years ago

fungiboletus commented 2 years ago

Hi,

I see that the default storage class value is standard, but it's not always there. For example on K3S the default storage class is named local-path.

I think it should perhaps be an empty string by default, to let kubernetes select the default storage class.

https://github.com/stardog-union/helm-charts/blob/4017033b8b755cc9a2abeadb44d4bb554917a931/charts/stardog/values.yaml#L71

igable commented 2 years ago

Yup, this is definitely a good idea.