stardog-union / helm-charts

Stardog Helm Charts
Apache License 2.0
9 stars 12 forks source link

Add support to basic ingress controller #80

Open marlonabarua opened 2 years ago

marlonabarua commented 2 years ago

Ingress controller support for the stardog helm chart. (Issue #79)

scardena commented 1 year ago

I haven't reviewd in fully yet, as I am waiting for tests to be written for this. Ideally we want to have a cluster up with the basic ingress working. One question I would ask is, why are you using $variables in this case? why not just pass the actual value right away? for example instead of doing:

{{- $fullName := include "stardog.fullname" . -}}

and then

metadata:
  name: {{ $fullName }}-ingress

I would just do:

metadata:
  name: {{ include "stardog.fullname" . }}-ingress