search

stardog-union / rocksdb

GNU General Public License v2.0
4 stars 1 forks source link

Feature: AES CTR encryption #6

Closed matthewvon closed 4 years ago

matthewvon commented 4 years ago

This PR has two major goals:

  1. Make rocksdb's existing env_encryption.{h,cc} fit normal C++ pattern of declarations in .h and definitions in .cc so that new encryption code can inherit from existing work.

  2. Implement AES CTR encryption in a manner that assumes users and programmers will need various types of migration of time: code migration, migration to / from encryption, and migration of underlying encryption keys.

matthewvon commented 4 years ago

FYI: Goal #1 to make EncrytpedEnv inheritable has been accepted and merged by Facebook.

matthewvon commented 4 years ago

@buzztroll I have executed the rocksdb "make check". It finished without errors. I am comfortable squash merging. I believe stardog/WORKSPACE pulls from a tag and will not be immediately impacted.