stardot / b-em

An opensource BBC Micro emulator for Win32 and Linux
http://stardot.org.uk/forums/viewtopic.php?f=4&t=10823
GNU General Public License v2.0
117 stars 58 forks source link

Remap keys doesn't seem to work on windows 7 #135

Closed richard-broadhurst closed 3 years ago

richard-broadhurst commented 3 years ago

I'm on Windows7 and by default @ (SHIFT ') does not produce (SHIFT :). I do settings|keyboard|remap and click on : and then press the ' key and OK. ' still produces _, not : and SHIFT ' still produces @, not . PS when I press ', it says that it is currently assigned to Alt-4.

richard-broadhurst commented 3 years ago

Experimenting, I tried to map ' to End and it crashed b-em. I didn't actually want that mapping.

SteveFosdick commented 3 years ago

Ok I can reproduce the crash. It seems to be a bit random. I suspect maybe the issue is caused by the keymapper updating a data structure the main window is also using.

SteveFosdick commented 3 years ago

Ok, I think I have this fixed now - it was seeing what should have been BBC keycodes as actions (i.e. things that control the emulator itself). That would have accounted for the crash (outside of an array bounds) and the non-working mapping.

Fix is in: https://github.com/stardot/b-em/tree/sf/keymapfix

SteveFosdick commented 3 years ago

The fix for this is merged.