search

stardot / beebasm

A portable 6502 assembler with BBC Micro style syntax
http://www.retrosoftware.co.uk/wiki/index.php/BeebAsm
GNU General Public License v3.0
84 stars 26 forks source link

Add -writes option to set number of disc writes in ssd catalogue #39

Closed ZornsLemma closed 11 months ago

ZornsLemma commented 4 years ago

tricky has implemented this and I've put the code on a branch here: https://github.com/ZornsLemma/beebasm/tree/tricky-writes

chriskillpack commented 2 years ago

I don't see anything controversial that would prevent it from going into the next beebasm release, though error checking on command line option values is inconsistent. It is acceptable to me that an invalid numeric value would set disk writes to 0, the default value without the -writes option.

Want to make a PR against proposed-updates so we can get it in?

ZornsLemma commented 2 years ago

Done! I haven't tweaked the validation, do you want me to take a look at that (I probably can't do it tonight though)? I'm quite happy for you to do it, of course!

chriskillpack commented 2 years ago

IMO missing validation isn't a blocker on this feature since we are missing validation on other command line options. We should address in a follow up PR.

ZornsLemma commented 2 years ago

See discussion on pull request #72, it looks like this was merged to proposed-updates a while ago and I forgot to note it here.

mungre commented 11 months ago

This is in release v1.10 as the "-cycle" option.