Closed mungre closed 7 years ago
My monitor is 1680x1050 which is also not in BeebEm's list and your change works fine for me. I'd suggest we treat multiple monitor support as a separate change, if someone wants to add it. As for the name, how about "Current Screen Resolution"?
I'm glad it works for you too. "Current Screen Resolution" is a much better name. There's a new commit with the change. Can you easily squash the commits as part of the merge? Or should I be doing that? I agree wrt multiple monitor support.
I'd prefer to have a linear commit history if possible, which means using rebase rather than merge commits. If you want to have a single commit for this change, I suggest you do an interactive rebase to squash the commits, then force push the branch. I'll then rebase this onto the master
branch.
I've squashed the commits. I was assuming you wouldn't want the history of minor changes in the main commit log and I'm surprised it's not more straightforward to achieve.
Anyway, once this is committed I'll rebase my other pull request. Which is the last one for now.
Thank you! I'll merge now.
Thank you.
My laptop has an unsupported 1366x768 screen and people have suggested full screen support for other modes.
This commit has a simple "View | DirectX Full Screen Modes | Screen Resolution" option which simply uses the current resolution when you switch to full screen. It does nothing if you select it while in a full screen mode. It doesn't aim for multiple monitor support, but I don't think beebem does anyway.
"Screen Resolution" isn't a great name, but I can't think of a better one.