search

stared / livelossplot

Live training loss plot in Jupyter Notebook for Keras, PyTorch and others
https://p.migdal.pl/livelossplot
MIT License
1.29k stars 143 forks source link

Replace the `:` character in Tensorboard path if the platform is Windows #77

Closed PhilMacKay closed 4 years ago

PhilMacKay commented 4 years ago

The OS is detected using sys.platform. From the official documentation (https://docs.python.org/3/library/sys.html#sys.platform), the value will be "win32" for any windows implementation, except Cygwin. It seems that Cygwin has its own way of handling special characters, and should behave like any POSIX compliant system regarding path special characters.

PhilMacKay commented 4 years ago

This pull request should solve issue #75

stared commented 4 years ago

Thanks for this PR. For consistency, I would prefer to have the same filenames for all systems.

(: is not that valuable to preserve on Windows or macOS)

After that change, I would be happy to accept this PR.

PhilMacKay commented 4 years ago

Sure! I just pushed that modification, let me know if there's anything else!

stared commented 4 years ago

@PhilMacKay Thank you a lot, merged!