stared / quantum-game

Quantum Game (old version) - a puzzle game with real quantum mechanics in a browser
http://v2016.quantumgame.io/
MIT License
343 stars 42 forks source link

Make playable on mobile devices #7

Closed mapmeld closed 6 years ago

mapmeld commented 7 years ago

Hi - I sent a Tweet out awhile back when I started working on making quantum-game playable on mobile.

Now that getting materials from the stockpile and moving to the next level is working, I'm thinking the best path forward is merge in this CSS and JS changes to improve the current mobile experience. The missing pieces are complex UI / help text which would be difficult to condense for mobile, but could be added in the future.

stared commented 7 years ago

It was cool to see that you made your modification!

While the game was intended to work well on mobile, as you see - we ended up adding to many things.

However, I tried to checkout it locally and it doesn't seem to work: screenshot 2017-06-29 22 34 56

Maybe you didn't commit some changes? (Or I am missing some steps in using it; but AFAIR you didn't install any new libraries, right?)

mapmeld commented 7 years ago

I think I see what's wrong here... when I was moving things around, xOffset was defined in one function but not another (where it is needed).

I've made a commit which should fix that.

stared commented 7 years ago

No errors in the console, but other things look exactly the same as in the previous screenshot.

mapmeld commented 7 years ago

Ok - I discovered that window.innerWidth is not reliable on Android. Made some commits and https://georeactor.github.io/quantum-game/ now works on my Android phone. Is that better?

mapmeld commented 6 years ago

I was just remembering this today. If it's still not working, let's get on an email or Slack chat to debug it

stared commented 6 years ago

Hi @mapmeld !

Sorry for making you wait so long. Yet, as you see - right now I don't have much time to develop QG.

screenshot 2017-11-05 12 32 52

To make it clear - making it more reactive is a big thing. And I value your contribution. :)

Yet, I am afraid that in the current form it is a hack - it solves an issue for one device, while adding possible complications for other settings.

If you could make it in a way that depending on resolution:

that works multi-device (also: one can easily test it on desktop browser), it would be more than happy to accept your PR (and help if needed). :)

For communication, I get email notifications from GitHub, so this channel should work. For more real time FB messenger would work (I am easy to find there) or Skype (piotr_migdal).