Open KJLJon opened 6 years ago
Interesting; I’d be happy to see a PR along these lines. FYI, the main considerations that went into the design of the CryptoCore:
Upon reflection, feel free to ignore that comment. It made a lot of sense for Crypto
to be set up as an accessible, independent component that was self-configuring. OTOH, the FileSystemInterface
could easily be managed by and/or through the Vault
class, so adding a bit of required boilerplate to use it is really a non-issue.
I assume you were thinking along the lines of adding a $filesys
argument to the Vault
constructor that, if left null
, would default to LocalFileSystem
(or perhaps inspect the given path for "http:" etc).
I think the file system calls in Vault should be abstracted into an interface so the vault could be stored in other locations and someone could leverage packages like flysystem.
Of course default it with the file system for ease of use.