search

starfederation / datastar-restructure-interim

MIT License
9 stars 4 forks source link

Add event options in SDK #12

Closed bencroker closed 2 weeks ago

bencroker commented 2 weeks ago

Adds event options to the option argument of all ServerSentEventGenerator helper methods and adds line breaks to make them easier to read.

delaneyj commented 2 weeks ago

We need to remove the references to a monotonic incrementing id

bencroker commented 2 weeks ago

@delaneyj I’ve removed the references to an incrementing ID and added retry to the event logic.

Can you please respond to @Superpat ’s comments above?

bencroker commented 2 weeks ago

Ok, resolved everything, final review please.