search

starfish-studios / Building-But-Better

Other
1 stars 2 forks source link

[Bug] Item Frames Disappear When Disconnecting and Reconnecting #11

Open kraftw opened 2 months ago

kraftw commented 2 months ago

Hello! I'm hosting a server and I found that specifically Building But Better is causing the labels from Storage Labels and item frames from Vanilla Minecraft to disappear when disconnecting and reconnecting. I'd really appreciate a fix for this as my friends really enjoy the labels and I really enjoy this mod :)

Minecraft Version: 1.20.1 Forge Version: 47.3.0 BBB Version: 1.1.1 Midnight Lib Version: 1.4.2

crispytwig commented 3 weeks ago

Hi, sorry for the late response, I've been super busy! Could you please specify how you figured out that this was Building But Better? Did you remove BBB and the issue was resolved?

rhino1998 commented 4 days ago

I can also confirm that this is happening with Storage Labels. A minimal forge install with just BBB and Storage Labels is sufficient to cause them to disappear on chunk reload. I haven't been able to observe an issue with vanilla item frames though.

The issue occurs when loading a saved label entity possibly due to an interaction with the HangingEntity mixin in BBB. https://mclo.gs/IMpiFYe