search

starfish-studios / Naturalist-Archive

🦌 Enhances the overworld by adding new wildlife with unique behavior!
https://starfish-studios.com/mods/naturalist/downloads
Other
55 stars 22 forks source link

[Swamp Update] Make bucket textures reusable for other mods #48

Closed cech12 closed 1 year ago

cech12 commented 1 year ago

I am the developer of the mod Ceramic Bucket. I decided to develop a library mod (BucketLib) to make it easier for mod developers to add own buckets.

To make your mod compatible with my library mod but also to enhance the compatiblity with other mods I split your bucket content textures from the underlying bucket to make them reusable. (I moved them one pixel lower or higher to fit into the lower bucket)

I also made the two PRs #37 (1.19) and #9 (1.18) for the snail bucket. But I have seen, that you are working on this feature branch and you added 2 more entities with bucket items.

You can test the compatibility when you install Ceramic Bucket and BucketLib (ideally bucketlib-1.19-1.0.3.3, because later I added the snail texture to be compatible until you merge this PR)

See also the Developer Guide to be compatible in the future. :)

cech12 commented 1 year ago

@crispytwig It would be nice, if you could review this PR :)

crispytwig commented 1 year ago

@crispytwig It would be nice, if you could review this PR :)

I do not receive notifications from tags, but I've been trying to be more active on GitHub. In the future, if you would like a faster response, feel free to join our Discord server or DM me personally. Thank you!

I have merged your PR for this branch. We are not currently using the others at this time, but I will visit those PR's later when we port things over. :-)

cech12 commented 1 year ago

@crispytwig Thanks for merging this PR! :)