starfishmod / jquery-oembed-all

A fork with improvements of the jquery-oembed project
http://starfishmod.github.com/jquery-oembed-all
387 stars 161 forks source link

Vimeo embeds default to SWF instead of iframe #34

Open joelgoodman opened 12 years ago

joelgoodman commented 12 years ago

I'm not sure what the issue is but every Vimeo embed I try defaults to the <embed> SWF version. Vimeo should default to the iframe embed, or maybe an option to force it?

starfishmod commented 11 years ago

This is what vimeo returns via their oembed endpoint - not sure I can change that - unless we make it an embedded instead - happy to accept a patch request for this.

joelgoodman commented 11 years ago

Not according to the Vimeo documentation or other implementations of oEmbed (ie, WordPress). http://developer.vimeo.com/apis/oembed – I ended up writing my own implementation that used the iframe returned. Perhaps this is using v1 of the API. They implemented a iframe across the board late in 2011.

starfishmod commented 11 years ago

Just tested http://vimeo.com/7100569 (from the http://developer.vimeo.com/apis/oembed page) and I got an iframe, have you got an example where it returns the swf?

joelgoodman commented 11 years ago

It was 6 months and ago and since left the job... I'll be doing work on that site again this weekend and will take a look again and report back.

starfishmod commented 11 years ago

:) yeah sorry realised it's been awhile since I did some work on this library and it's tickets...

joelgoodman commented 11 years ago

No worries :)