search

starfishmod / jquery-oembed-all

A fork with improvements of the jquery-oembed project
http://starfishmod.github.com/jquery-oembed-all
386 stars 160 forks source link

oEmbed https issues #87

Open nicolaasmatthijs opened 11 years ago

nicolaasmatthijs commented 11 years ago

When using oEmbed on an https page, security conscious browsers such as Chrome won't load some of the http jsonp and swf content.

[blocked] The page at https://mydomain.org/mypage ran insecure content from http://flickr.com/services/oembed?format=json&url=http%3A//www.flickr.com/p…et-72157633424719011&jsoncallback=jQuery20006060085988137871_1372157077449.

In this PR, I've made the following providers protocol agnostic and tested this on both http and https:

The same approach would probably work for the other providers as well, but I haven't fixes and/or tested any of those yet.

dieseltravis commented 11 years ago

Interesting, I was looking into writing a proxy service to solve this issue, but I think I'll give your solution a try first.

nicolaasmatthijs commented 10 years ago

@starfishmod : Is there any chance that this can be merged? Cross-protocol embedding is becoming an increasingly big problem in the latest browser versions.

LGCambra commented 10 years ago

The NFL would like to continue support for this plugin. Please re-submit your pull request with https://github.com/nfl/jquery-oembed-all. Thank you.