search

starfive-tech / JH7100_ddrinit

Other
16 stars 15 forks source link

Missing license information #5

Closed tpetazzoni closed 3 years ago

tpetazzoni commented 3 years ago

There is no license file or license information. Some files have a BSD-3c license, some have an Apache-2.0 or GPL-2.0+ license. There is even a u-boot.bin.out file being generated, so one wonders if parts of U-Boot are being used, which would make the whole project GPL-2.0 licensed.

Could the licensing be clarified ?

pdp7 commented 3 years ago

@yimingyiming @MichaelZhuxx could you please comment on this?

pdp7 commented 3 years ago

There is now a license in this commit: https://github.com/starfive-tech/beagle_ddrinit/commit/cfa2230f834ab4c1ff0176ea5aebc7596bb3dfb5

@tpetazzoni does that satisfy what you were looking for?

pdp7 commented 3 years ago

@MichaelZhuxx please add SPDX license header to all the files with StarFive copyright. They need this:

/* SPDX-License-Identifier: GPL-2.0-or-later */
MichaelZhuxx commented 3 years ago

@pdp7 please check it https://github.com/starfive-tech/beagle_ddrinit/commit/82e631d844685fd146f90fd1f2925579f2811430 and also release a new binary based on your draft https://github.com/starfive-tech/beagle_ddrinit/releases/tag/ddrinit-2133-210607

pdp7 commented 3 years ago

@MichaelZhuxx thank you for adding those SPDX headers.

I also have created a LICENSE file. Please review PR https://github.com/starfive-tech/beagle_ddrinit/pull/9