starfixdev / starfix

Utility to easily open and operator on source code via url links from your browser
Apache License 2.0
26 stars 21 forks source link

Manifest V3 #106

Open Kshitiz-Mhto opened 1 year ago

Kshitiz-Mhto commented 1 year ago

Is there any plan for migrating from Manifest V2 to Manifest V3 soon for Google Chrome Extension. Manifest version 2 is deprecated, and support will be removed in 2023 such message is showing up while i am trying to load manifest file in my Chrome.

The transition of Chrome extensions to Manifest V3 blog,

for more detail About Manifest V3 timeline

Manifest V2 support timeline

fahad-israr commented 1 year ago

Should do this. Need to fix automatic release pipeline for chrome first. Also what about Firfox compatibility with v3?

Kshitiz-Mhto commented 1 year ago

Hi @fahad-israr @maxandersen i tried some changes in manifest and try to migrate from V2 to V3 using Mozilla migration for manifest Doc . I tested on my local machine, it didnot show error in both chrome and firefox.

But, in firefox,
the The developer preview of Manifest V3 is available after Firefox 101. Generally, it is not available for older versions, But can be done by turning on MV3 features, ie.

    Set extensions.manifestV3.enabled to true
    Set xpinstall.signatures.required to false

By default, these were true in my firefox. Steps to turn on MV3 feature

type about:config in firefox search bar and search the above mentioned options.


In case of Chrome, Every thing went good :+1:

Changes i made: manifest

fahad-israr commented 1 year ago

assume you are the end user and you install it from the chrome/firefox extension store, would everything work fine ? also please raise a pr for the changes you've done.

Kshitiz-Mhto commented 1 year ago

assume you are the end user and you install it from the chrome/firefox extension store, would everything work fine ? also please raise a pr for the changes you've done.

i have tested by loading files on Chrome, it went all good. but in firefox , it is not working as expected.

Kshitiz-Mhto commented 1 year ago

In firefox, it is not able to provide href attribute to <a> tag as shown in figure:

bottomInspect


as it should provide according to line 32 in context.js content

fahad-israr commented 1 year ago

try if you can look for a workaround. Or else a meachnism to upgrade to V3 atleast for Chrome. Also, what version of chrome did you test it upon ? most people would already be upon chrome version released in last 6 months. would find very very few users using versions older than that ig.

Kshitiz-Mhto commented 1 year ago

I tested on Chrome, It worked as expected. I am still experimenting to make it work in firefox also. chrome version 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/109.0.0.0 Safari/537.36' firefox version "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0"