Patch : To handle file names with spaces.

starfixdev / starfix

Utility to easily open and operator on source code via url links from your browser

Apache License 2.0

26 stars 21 forks source link

Patch : To handle file names with spaces. #74

Closed fahad-israr closed 3 years ago

fahad-israr commented 3 years ago

Add url decoer to handle file names with spaces.
Resolves https://github.com/starfixdev/starfix/issues/72

fahad-israr commented 3 years ago

@maxandersen have made suggested changes already @commmit . It solves the linked issue . As far as the tests are concerned I am not sure what tests to add here and would need suggestion on that and I am opening a separate issue so that we don't miss that .

maxandersen commented 3 years ago

To test the code we need the code to be testable. Atm all the main code is in one big method and thus very hard to write tests for it.

fahad-israr commented 3 years ago

To test the code we need the code to be testable. Atm all the main code is in one big method and thus very hard to write tests for it.

I've opened a separate Issue for adding Tests . I'd try to break down code in different functions (though we still have many ) and probably that could help in testing .