starfixdev / starfix

Utility to easily open and operator on source code via url links from your browser
Apache License 2.0
26 stars 21 forks source link

Added picocli code-gen #85

Closed fahad-israr closed 3 years ago

fahad-israr commented 3 years ago

Trying to Resolve Issue: https://github.com/starfixdev/starfix/issues/83

fahad-israr commented 3 years ago

@maxandersen This PR resolves https://github.com/starfixdev/starfix/issues/83 I've tried running the generated native binary and it works now .

fahad-israr commented 3 years ago

@maxandersen The Linked issue is resolved but I am facing another issue now. I am facing issue with starfic config command. When I run it in development mode using ./mvnw compile quarkus:dev -Dquarkus.args="config" it works fine. But when I run the native binary (Native Executable ) it shows warning to me and the config properties aren't read in the app. WARN - could not read defaults from /Users/devfi/.config/starfix.yaml: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance ofjava.util.Properties(no Creators, like default constructor, exist): no default constructor found at [Source: (File); line: 2, column: 1]

maxandersen commented 3 years ago

I can't imagine why we would need to add the picocli annotation processor to "fix" #83 that sounds more like an "accidental" fix.

maxandersen commented 3 years ago

What made you think the annotation processor would help ?

maxandersen commented 3 years ago

so same solution as last is to add @RegisterForReflection on the class having issues.

reason it fixes it is that the annotation processor is apparently doing more than Quarkus picocli integration does. opened https://github.com/quarkusio/quarkus/issues/19289 to get it fixed there.

maxandersen commented 3 years ago

opened #87 for "right" fix.