search

starforcraft / Botany-Pots-Tiers

Adds Better Botany Pots from Botany Pots
GNU Lesser General Public License v2.1
0 stars 8 forks source link

Large amounts of pots cause player timeouts and large network spikes #5

Closed DatenThielt closed 2 years ago

DatenThielt commented 2 years ago

After spending 3 hours debugging a local server that I run for a friend of mine we found that this mod was causing an issue spesific to his player.

Mod Version: 1.141 MC Version: 1.16.5

We had roughly 150 pots of the first tier out in a sky-block mod-pack (Project Isothermal Expert). 40ish were filled with dirt and seeds. 100ish had just dirt and 10 had nothing. The dirt used was Supremium.

When the player logged in his ping would start slowly rising. until it got to 2000ish and it timed him out.

After removing all the pots his ping would return to normal.

I'm not sure if its the empty pots, pots with dirt or just the sheer amount of pots that is causing the issue but it is 100% this mod. placing out 150 normal botany pots does not cause the same issue, I understand these are faster but they should not cause a timeout or ping to rise.

If you need any additional information please let me know.

starforcraft commented 2 years ago

Can you maybe run spark?

DatenThielt commented 2 years ago

I've never used spark before but I can give it a go for sure, The odd part was that it was only happening to the one player who was not local to the server , making it seem somewhat network related. But once I figure out spark I will let you know

DatenThielt commented 2 years ago

I'm not super sure if this is what you need but this is a profiler run without that player being on, but the 150 pots present as described above

https://spark.lucko.me/LVOq17YW6O

DatenThielt commented 2 years ago

And this profiler is from when he is on the server

https://spark.lucko.me/q4nDa80QSy

DatenThielt commented 2 years ago

and finally this is with the pots removed

https://spark.lucko.me/EYfrIv4JxN

starforcraft commented 2 years ago

Hmm weird... grafik grafik

starforcraft commented 2 years ago

Did you take that picture when it wasn't lagging yet?

DatenThielt commented 2 years ago

The first and second profile were taken when the pots were in world, This is only causing the other players ping to go up to 2000-4000. The server itself is still performing fine for myself and TPS/other mods are running fine

The final picture is taken with the pots removed, My friends ping drops down to 70ish at this point. I dont know if there is a network profiler included with spark?

starforcraft commented 2 years ago

Ah okay, so its a client side issue. Can you maybe send a screenshot with Observable mod?

DatenThielt commented 2 years ago

It appears I cannot get Observable to load on either the server or the client I am afraid, Are there any other tools that could be used?

starforcraft commented 2 years ago

I think this issue is fixed in 1.18.2 and up so I am going to close this issue

sharpskull2 commented 2 years ago

Please fix this issue on 1.16, or label the 1.16 version of this mod as deprecated. this isn't just a small bug that would fly under the radar most of the time. This is a fairly game/server crippling bug that can make the game unplayable for anyone that isn't on the same network as the server.

Lots of packs that would make use of this mod are going to make use of them in large quantities, and in doing so are going to cause problems for anyone playing on a server with friends or other people. You can't just expect everyone to go to 1.18 when there are plenty of packs that are still being developed or released for 1.16

again, please look into fixing this bug, or at least say on the mod page that the 1.16 version is deprecated and should no longer be used