stargate-rewritten / Stargate-Bukkit

The original, and still the best, survival-friendly portal plugin.
https://sgrewritten.org/paper
GNU Lesser General Public License v3.0
28 stars 13 forks source link

A gate can be created lacking a button #320

Closed Thorinwasher closed 3 months ago

Thorinwasher commented 4 months ago

Use Case

Reproduction steps:

Place an empty sign on a valid control position on a gate, the gate should not generate but now there's a sign there. Place another sign on the other valid control position and write a name for the gate, nothing more. The result should be something like this image Where the gate now has 2 signs assigned to it, but no button, so it's not possible to activate

Proposed Solution

Up to discussion. One way would be to throw an exception during gate creation, thereby stopping the creation of the portal, if the portal is not always on, that is. If it's always on, then this does not matter, and can be seen as expected behavior

Additional Context

No response