stargate-rewritten / Stargate-Bukkit

The original, and still the best, survival-friendly portal plugin.
https://sgrewritten.org/paper
GNU Lesser General Public License v3.0
33 stars 12 forks source link

Migrator fails to handle block id changes. #345

Closed Pheotis closed 5 months ago

Pheotis commented 5 months ago

Bug Description

Importing portals with gateformats that use blocks which have changed IDs leads to illegal portal state.

Reproduction Steps

  1. In an old version (in this case 1.17), make a format with a block mojang has changed the ID of.

    portal-open=NETHER_PORTAL
    portal-closed=GRASS
    button=STONE_BUTTON
    toowner=false
    X=DRAGON_HEAD
    -=OBSIDIAN
    
    XX 
    X..X
    -..-
    X*.X
    XX 
  2. Load the portal in the latest version with the latest stargate.

Desired Behaviour

Using XMat or something, the gatefile should be changed to reflect the new IDs.

Observed Behaviour

Portals are loaded, but do not function. image image

Trace Logs

No response

Other Information

Tested on windows, with latest legacy 1.17.1 on spigot, to latest rewrite 1.20.6 on paper.