search

stargate-rewritten / Stargate-Mechanics

An expansion addon for features that break StarGate's user-intuitiveness principle (vanilla+ features that would be too overwhelming to include in the core)
https://sgrewritten.org/philosophy
Mozilla Public License 2.0
0 stars 0 forks source link

Unwanted overriding of default coloring when the color has not been changed #32

Open Pheotis opened 3 weeks ago

Pheotis commented 3 weeks ago

Attempting to set default colours still results in an ugly mess.

sgi config DEFAULT_SIGN_COLOR blue Produces this mess (shown beside a blue dye for comparison) image

What is even happening here? This isn't something that needs to be fixed before the alpha, but it does eventually need to be fixed.

Thorinwasher commented 2 weeks ago

Why is this in SGC?

Do you mean we should fix this in SGC or something?

Thorinwasher commented 2 weeks ago

With further research, this is an issue with SGM enforcing the dyecolor of the sign to be the actuall color of the sign.

Currently the default dyecolor applied to the sign is aproximated to be the one that is closest to our customized color, in this case for BLUE we choose #8e9ada, which really is closer in the color spectrum to the LIGHT_GRAY dye color.

From what I rememeber, SGM implements a coloring feature very similar to core, do we really need to have it?

Anyhow the current implementation does not seem to respect the default coloring setting in core. I think the colors are supposed to only override the default coloring whenever the user has actually colored the sign.