search

starhawking / python-terrascript

Create Terraform files using Python scripts.
BSD 2-Clause "Simplified" License
516 stars 76 forks source link

Fail builds on files modified by Black #127

Closed ilons closed 3 years ago

ilons commented 4 years ago

In order to make it easier for contributor to keep a consistent code style, we should start fail builds for any files changed when running make black in the build. This would ensure that code changes adhere to the code style dictated by Black.

mjuenema commented 4 years ago

I agree, but to ensure consistent outcomes Black must be pinned to a specific version.

ilons commented 4 years ago

I agree, but to ensure consistent outcomes Black must be pinned to a specific version.

Ah yes, this is coming in as part of https://github.com/mjuenema/python-terrascript/pull/124

mjuenema commented 4 years ago

:+1: