search

starhawking / python-terrascript

Create Terraform files using Python scripts.
BSD 2-Clause "Simplified" License
515 stars 76 forks source link

Some extra vSphere objects, JSON issue #36

Closed austin-millan closed 6 years ago

austin-millan commented 6 years ago

Addresses #35 and #3.

mjuenema commented 6 years ago

Hi Austin, thanks for the pull request. I already have a potential solution for issue #3 so I am probably not going to merge that part of your pull request. That part that covers issue #33 is certainly going to get merged but it is going to take a few days. I'd also like to write a test case for issue #33, like the others in https://github.com/mjuenema/python-terrascript/tree/develop/tests. Feel free to add one yourself if you like. Can you also leave a note in the CHANGELOG.md about your fix to issue #33 so I don't forget!!!

mjuenema commented 6 years ago

I merged this into develop.