search

starhawking / python-terrascript

Create Terraform files using Python scripts.
BSD 2-Clause "Simplified" License
515 stars 76 forks source link

Missing vSphere Data Source: Datastore, Terrascript.update() incl. #42

Closed austin-millan closed 6 years ago

austin-millan commented 6 years ago

Addresses #41, and includes PR #37 's Terrascript.update() method

codecov-io commented 6 years ago

Codecov Report

Merging #42 into master will decrease coverage by 0.16%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #42      +/-   ##
=========================================
- Coverage   98.77%   98.6%   -0.17%     
=========================================
  Files         138     138              
  Lines        2358    2365       +7     
=========================================
+ Hits         2329    2332       +3     
- Misses         29      33       +4
Impacted Files Coverage Δ
terrascript/vsphere/d.py 100% <100%> (ø) :arrow_up:
terrascript/__init__.py 94.57% <33.33%> (-2.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3edb2f...fa9da42. Read the comment docs.

mjuenema commented 6 years ago

I moved house last week and my computers are still in boxes. So please be a bit patient before I can merge this pull request. Thanks, Markus.

austin-millan commented 6 years ago

I'm going to make a new PR request for my specific issue