search

starhawking / python-terrascript

Create Terraform files using Python scripts.
BSD 2-Clause "Simplified" License
516 stars 76 forks source link

Missing vSphere Data Source: Datastore #44

Closed austin-millan closed 6 years ago

austin-millan commented 6 years ago

Addresses #41

codecov-io commented 6 years ago

Codecov Report

Merging #44 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   98.77%   98.77%   +<.01%     
==========================================
  Files         138      138              
  Lines        2358     2366       +8     
==========================================
+ Hits         2329     2337       +8     
  Misses         29       29
Impacted Files Coverage Δ
terrascript/vsphere/r.py 100% <100%> (ø) :arrow_up:
terrascript/vsphere/d.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3edb2f...4a5af11. Read the comment docs.

mjuenema commented 6 years ago

Hi @austin-millan , I just moved house and started a new job and unfortunately that leaves me with very little time for other things at the moment. I promise that I am going to look into this as soon as I can. Sorry!

mjuenema commented 6 years ago

Hi @austin-millan do you want to re-submit the pull request or has this been resolved? Regards, Markus

austin-millan commented 6 years ago

Sure thing, check out PR #52. It's just to get terrascript in sync with the vsphere plugin