search

starhawking / python-terrascript

Create Terraform files using Python scripts.
BSD 2-Clause "Simplified" License
515 stars 76 forks source link

update azurerm resource and the function `interpolated` #53

Closed LEUNGUU closed 6 years ago

LEUNGUU commented 6 years ago

Thanks for your perfect python-terrascript! But I have found some bugs during using it. First, we use the resource 'azurerm_virtual_machine_data_disk_attachment' but the source code doesn't contain it and I add it. Second, when generating the output, I need to add the parameter 'depends_on' like this:
"bastion-host": { "depends_on": ["${openstack_compute_instance_v2.bastion_1}"] "value": ["${openstack_compute_instance_v2.bastion_1.name}"] } But I find that function 'interpolated' cannot generate '${openstack_compute_instance_v2.bastion_1}' and raise error due to missing one close curly brace. So i change it and it works. Am I right?

codecov-io commented 6 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #53      +/-   ##
========================================
+ Coverage   98.88%    99%   +0.11%     
========================================
  Files         138    138              
  Lines        2604   2602       -2     
========================================
+ Hits         2575   2576       +1     
+ Misses         29     26       -3
Impacted Files Coverage Δ
terrascript/__init__.py 98.72% <100%> (+1.83%) :arrow_up:
terrascript/azurerm/r.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8466ac2...9e221c2. Read the comment docs.