search

starkillerOG / reolink_aio

Reolink NVR/camera API PyPI package
MIT License
65 stars 13 forks source link

Added set_image function for image settings (bright, contrast...) #27

Closed zerinrc closed 1 year ago

starkillerOG commented 1 year ago

@zerinrc Why did you close this? I was just about to merge after pushing some small tweaks I made.

zerinrc commented 1 year ago

I'm sorry. I'm not familiar with GitHub, and yesterday make the changes you requested for sending individual parameters. I've created a new pull request. I don't touch it anymore... 🤦‍♂️ my fault.

starkillerOG commented 1 year ago

@zerinrc no problem. For the next time, you can just make changes on the existing pull request, no need to open a new one.

mnpg commented 1 year ago

Hi @starkillerOG, In that PR, i ain't seen some capabilities dependances in the code for these Isp settings or i'm wrong. For my E1-Outdoor, the Hue setting isn't present, and it's normal because in the GetAbility, ispHue ver parameter is set to 0. All these settings depends on these capabilities : ispBright, ispContrast, ispSatruation (yes, it's the real name), ispSharpen and ispHue

starkillerOG commented 1 year ago

I just added the check of the capabilities in commit: https://github.com/starkillerOG/reolink_aio/commit/21adca678dd4d568e1d8e37ac95b547c3f170bc7 Thanks for making me aware of this.