search

starkillerOG / reolink_aio

Reolink NVR/camera API PyPI package
MIT License
65 stars 13 forks source link

set_image now can accept individual parameters #29

Closed zerinrc closed 1 year ago

starkillerOG commented 1 year ago

@zerinrc I made some small tweaks to make sure it passes all the styling checks. I think it looks good now.

I will publish a new version of reolink-aio in a few days, which will then include this new code.

Thank you very much for your contribution, looking forward to your next pull request.

zerinrc commented 1 year ago

Thanks to you, for this library. :)

mnpg commented 1 year ago

Hi @starkillerOG, In that PR, i ain't seen some capabilities dependances in the code for these Isp settings. For my E1-Outdoor, the Hue setting isn't present, and it's normal because in the GetAbility, ispHue ver parameter is set to 0. All these settings depends on these capabilities : ispBright, ispContrast, ispSatruation (yes, it's the real name), ispSharpen and ispHue

starkillerOG commented 1 year ago

@mnpg I just added the check of the capabilities in commit: https://github.com/starkillerOG/reolink_aio/commit/21adca678dd4d568e1d8e37ac95b547c3f170bc7 Thanks for making me aware of this.

starkillerOG commented 1 year ago

@zerinrc reolink-aio 0.6.0 has just been released, which includes your new code, it is now ready to be used.