starkillerOG / reolink_aio

Reolink NVR/camera API PyPI package
MIT License
79 stars 16 forks source link

Raise original exception on login failure #55

Closed nicolasbrailo closed 9 months ago

nicolasbrailo commented 10 months ago

The current implementation retries to login in http mode when https login fails. If http login fails too, then it will raise the exception of the retry attempt, masking the original error. This change raises the https loging exception when this operation fails (unless the http login succeeds) and instead masks the retry exception, if it happens.

starkillerOG commented 9 months ago

@nicolasbrailo Thank you very much for this PR!