search

starkillerOG / reolink_aio

Reolink NVR/camera API PyPI package
MIT License
79 stars 16 forks source link

Password contains incompatible special character #73

Closed Wikilicious closed 3 months ago

Wikilicious commented 3 months ago

Describe the bug My password was working in HA 2024.7.4 however, after "updating" to HA 2024.8.1 the integration added FORBIDEN_CHARS and doesn't allow me to connect.

To Reproduce 2024-08-15 10:02:45.372 WARNING (MainThread) [reolink_aio.api] Reolink password contains incompatible special character, please change the password to only contain characters: a-z, A-Z, 0-9 or @$*~_-+=!?.,:;'()[]

Expected behavior The expectation was for the integration to continue working.

Screenshots image

Environment:

Core - 2024.8.1
Supervisor - 2024.08.0
Operating System - 12.4
Frontend - 20240809.0

I have seven different reolink cameras and they all have the same error after updating Home-Assistant.

Additional context In my mind, password validation should be done by the device itself.

Suggested Fix Remove the arbitrarily restrictions on allowed characters. Let the device itself decide what's allowed.

starkillerOG commented 3 months ago

Duplicate of https://github.com/home-assistant/home-assistant.io/issues/34199 and https://github.com/home-assistant/core/issues/123302 and a few others

See my explination here: https://github.com/home-assistant/core/issues/123302#issuecomment-2274337355

Sorry for the inconveniance of having to make a new user/change the password.

If you appreciate the reolink integration and want to support its development, please consider sponsering the upstream library or purchase Reolink products through this affiliate link.