search

starkillerOG / reolink_aio

Reolink NVR/camera API PyPI package
MIT License
79 stars 16 forks source link

Port argument is now a keyword argument #8

Closed calidbaba closed 1 year ago

calidbaba commented 1 year ago

Hi, thanks for your work on this library :-)

Was just setting it up and tried the example from the readme. It seems that my camera 510wa just return 302 on port 80, so I wanted to change to port 443. However this did not have any effect, and I could see in the error that it stilled tried to connect to port 80.

After some digging in the source code it seems that port should be the 4th argument, not the second as it is now.

cheers

starkillerOG commented 1 year ago

@calidbaba you are totally right, I have not updated the README since I started work on this library. A lot has changed, so probably there will be more mistakes. Once I am done adding features and the HomeAssistant Reolink integration is running smoothly for everyone, I will clean up the readme and put some better examples in there and document more of the API.

I will merge this now, since you are correct.