search

starknet-io / SNIPs

Starknet Improvement Proposal repository
MIT License
158 stars 99 forks source link

Immutable Component Config (SRC-107) #107

Open ericnordelo opened 2 months ago

ericnordelo commented 2 months ago

Discussion:

https://community.starknet.io/t/immutable-component-config/114434

Abstract

This standard proposes a mechanism to allow setting components’ configurable constants in the implementing contracts without needing to save them in storage. Component providers can leverage this standard to make them configurable while keeping the constants hardcoded in the bytecode, removing the extra storage reads required if storage were to be used for this matter.

SNIP number

I followed the PR number pattern to assign 107.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

ericnordelo commented 1 month ago

@amanusk If I recall correctly you are also a maintainer of this repo now? tagging you for review in case that is correct. cc @ArielElp

leo-starkware commented 1 month ago

Hey @ericnordelo can you add the mandatory section "Rationale" (IMO you could simply rename the section "Motivation" which is optional) and "Security considerations"? Also tagging @ArielElp in case there are comments to address before merging to main

ericnordelo commented 3 weeks ago

Hey @leo-starkware, sorry for the delay. Updates applied!

ericnordelo commented 2 weeks ago

What is the rationale behind the 23? It is not easier to track SNIPs by the PR number (like EIPs) so they can be safely referenced when they are drafts? We are also already referencing this in the library as SRC-107.