search

starknet-io / SNIPs

Starknet Improvement Proposal repository
MIT License
159 stars 99 forks source link

SNIP-14: Non-fungible Tokenbound Accounts #72

Closed Darlington02 closed 4 months ago

github-actions[bot] commented 9 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] commented 8 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] commented 7 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

Darlington02 commented 7 months ago

@AbdelStark @ArielElp

github-actions[bot] commented 5 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

Darlington02 commented 5 months ago

..

dor-starkware commented 5 months ago

Hi @Darlington02,

Thank you for your submission. After reviewing SNIP-72, we have a couple of points that need addressing to comply with the SNIP-1 guidelines:

  1. Date Format: The creation date has a small typo. Please correct it to "2024-01-08".

  2. External Links: According to SNIP-1, external links should be avoided as they can disappear or change unexpectedly. Instead, please include any images, diagrams, and auxiliary files directly within a subdirectory of the assets folder for this SNIP. The path should be assets/snip-13, and you should use relative links such as ../assets/snip-13/image.png when linking to these files.

Once these changes are made, we can proceed with the review process.

Darlington02 commented 5 months ago

thank you @dor-starkware. would we also be renaming to snip-13?

leo-starkware commented 5 months ago

@Darlington02 We merged snip-13 recently, so this would be snip-14

Darlington02 commented 5 months ago

Hi @Darlington02,

Thank you for your submission. After reviewing SNIP-72, we have a couple of points that need addressing to comply with the SNIP-1 guidelines:

  1. Date Format: The creation date has a small typo. Please correct it to "2024-01-08".
  2. External Links: According to SNIP-1, external links should be avoided as they can disappear or change unexpectedly. Instead, please include any images, diagrams, and auxiliary files directly within a subdirectory of the assets folder for this SNIP. The path should be assets/snip-13, and you should use relative links such as ../assets/snip-13/image.png when linking to these files.

Once these changes are made, we can proceed with the review process.

Hi @dor-starkware I've fixed all these:)

Darlington02 commented 4 months ago

Hey @dor-starkware pinging about this. Any updates?

dor-starkware commented 4 months ago

Hey @Darlington02,

Sorry for the delay. This branch has now been merged.