starknet-io / SNIPs

Starknet Improvement Proposal repository
MIT License
155 stars 96 forks source link

SNIP-6 security clarifications #82

Closed sgc-code closed 2 months ago

sgc-code commented 4 months ago

Add clarification about how the data to sign must include the chain id and the account address to avoid signature replays

github-actions[bot] commented 3 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

sgc-code commented 3 months ago

hi @ArielElp can we please merge this one, it's a clear improvement that will improve safety