search

starknet-io / SNIPs

Starknet Improvement Proposal repository
MIT License
158 stars 99 forks source link

SNIP-2 update notation #83

Closed nbundi closed 5 months ago

nbundi commented 6 months ago

The Starknet/Cairo community has converged to use snake case notation.

The original SNIP-2 standard, published in June 2022, suggested camel case.

This update introduces snake case as the default and camel case as an optional "extension" for backwards compatibility.

The update further upgrades the syntax from Cairo 0.8.0 to 2.6.0.

This approach is inline with e.g. OZ's token contract implementations, which are predominantly used in the community, and account for the fact that some protocols in fact rely on the camel case API.

This change is Reviewable

nbundi commented 5 months ago

Yes sorry my comment is misleading. What I meant was not that new events are added but that the Transfer and Approve events suggested here, just like EIP-20, in fact require to index the fields that you propose in #84

So if SNIP-2 gets updated as suggested here and StarkGate's token contracts reflect these changes, then be definition they would index the respective fields.

re Cairo syntax/version you're right ofc will fix

nbundi commented 5 months ago

fixed @ArielElp

re name and symbol returning ByteArray, is this really a concern? these fields are more used for off-chain purposes in general no?