search

starknet-io / SNIPs

Starknet Improvement Proposal repository
MIT License
158 stars 99 forks source link

bug: Clarification on merged SNIP status #88

Closed boyuanx closed 2 months ago

boyuanx commented 4 months ago

Currently, most if not all merged SNIPs still have their statuses as "Draft". I'm wondering if this is intentional, or should they be "Final"?

dor-starkware commented 4 months ago

Hi @boyuanx,

I plan to review all the SNIPs in the main branch and ensure that the authors update their statuses to the appropriate ones according to SNIP-1 guidelines. Thank you for bringing this to my attention. I'll make sure we address this as soon as possible.

boyuanx commented 4 months ago

@dor-starkware I also noticed a lot of SNIP numbers do not properly adhere to the corresponding PR number, as specified in SNIP-1

dor-starkware commented 4 months ago

@boyuanx, Just to clarify, are you noting a discrepancy between the SNIP numbers and the corresponding PR numbers in the main branch?

According to SNIP-1 guidelines:

Once the SNIP is ready for the repository, the SNIP editor will: Assign a SNIP number (generally the PR number, but the decision is with the editors)

This indicates that while the SNIP number is generally the same as the PR number, the final decision lies with the editors, and they may assign a different number if deemed necessary. When I merge a new PR, I assign it a SNIP number in a sequential manner to make the SNIPs more organized.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!