search

starknet-io / get-starknet

StarkNet wallet <-> dApp bridge
MIT License
155 stars 110 forks source link

Improvements of core exports #223

Closed PhilippeR26 closed 6 months ago

PhilippeR26 commented 6 months ago

@dhruvkelawala (info : @ivpavici )

  1. In core, StarknetChainId and Permission are enums. Permission is exported as enum, but StarknetChainId is exported as type. To be able to use correctly StarknetChainId, it's proposed to export it also as an enum.
  2. During tests of Starknet.js WalletAccount class in a DAPP, it appeared that it's beneficial for DAPP devs to be able to import scanObjectForWallets & isWalletObj. It's proposed to add these 2 exports in core.
avimak commented 6 months ago

lgtm, @dhruvkelawala if no objections pls merge 👍