search

starknet-io / get-starknet

StarkNet wallet <-> dApp bridge
MIT License
154 stars 106 forks source link

feat: virtual wallet support + Metamask integration #227

Closed naorye closed 1 week ago

naorye commented 3 months ago

Virtual wallet is a wallet instance that has no implementation, which will be loaded upon calling to enable method. Virtual wallet include two important methods:

  1. hasSupport() - async, return true whether this wallet is supported
  2. loadWallet() - async, download and return the actual wallet instance Wallet vendors that requires additional code will be supported in get-starknet via virtual wallet.

For example, in Metamask integration, hasSupport() returns true if MetaMask extension exists and if there is a snap support. In such case, MetaMask will be an option for the available wallets. Once the user will choose Metamask and will enable it, the actual wallet implementation will be downloaded and return to the user.

stanleyyconsensys commented 2 months ago

The URL : https://s3.eu-central-1.amazonaws.com/dev.snaps.consensys.io/get-starknet/remoteEntry.js is developed base on current master/main branch of get-starknet

hence it will not work to the get-starknet:develop branch

naorye2 commented 2 months ago

@stanleyyconsensys Let me know which url to use.