starknet-io / get-starknet

StarkNet wallet <-> dApp bridge
MIT License
160 stars 115 forks source link

Introduce Environment Variable for remoteEntry.js URL to Facilitate Local Testing #255

Closed khanti42 closed 5 months ago

khanti42 commented 5 months ago

The current implementation has the remoteEntry.js URL hardcoded, which poses challenges for local testing and integration with MetaMask StarkNet Snap. To address this issue, we propose introducing an environment variable to dynamically handle the URL. This enhancement will improve the flexibility and ease of testing different environments.

We suggest adding a new environment variable named VITE_MM_FED_URL. This variable will allow developers to specify the remoteEntry.js URL during local development. If the variable is not set, the system will default to the original hardcoded URL, ensuring backward compatibility.

file concerned : packages/core/src/wallet/metamaskBridge.ts

khanti42 commented 5 months ago

I close this as we don't want to add MM specific things here. This will be available on a fork here