starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.
https://starkgate.starknet.io
Apache License 2.0
148 stars 84 forks source link

fix(2878552430): User routes to the main screen even if not choose an L2 wallet #232

Closed galuzan-starkware closed 2 years ago

galuzan-starkware commented 2 years ago

Description of the Changes

This fix is for a scenario where the user closes the popup window of the wallet connection and goes into the main application screen. the solution is to add another check in the if statement which checks that the address that we receiving from the get-starknet library is something not falsy (in our case is an empty string)

Checklist


This change is Reviewable

github-actions[bot] commented 2 years ago

This branch was successfully deployed :rocket: https://pr232-goerli.starkgate.starknet.io

dan-ziv commented 2 years ago

@galuzan-starkware

  1. Please Add description to the PR
  2. Please change the title to reflect better the issue
dan-ziv commented 2 years ago

:tada: This PR is included in version 1.7.0-dev.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.7.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: