starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.
https://starkgate.starknet.io
Apache License 2.0
148 stars 84 forks source link

feat(2890253606): New design for main deposit modal #273

Closed yairans-starkware closed 2 years ago

yairans-starkware commented 2 years ago

Description of the Changes

Solves #2890253606


Checklist


This change is Reviewable

netlify[bot] commented 2 years ago

Deploy Preview for goerli-starkgate ready!

Name Link
Latest commit 5478c1d5da60d7ec52e1faecb2762eb0ca84d746
Latest deploy log https://app.netlify.com/sites/goerli-starkgate/deploys/630cc6ffa08721000990b151
Deploy Preview https://deploy-preview-273--goerli-starkgate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for integration-starkgate ready!

Name Link
Latest commit 5478c1d5da60d7ec52e1faecb2762eb0ca84d746
Latest deploy log https://app.netlify.com/sites/integration-starkgate/deploys/630cc6ffe1636f0008a56722
Deploy Preview https://deploy-preview-273--integration-starkgate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

galuzan-starkware commented 2 years ago

Please, next time, let's try to separate the task into sub-tasks and separate PRs. It's challenging to review this and know the goal of each change

galuzan-starkware commented 2 years ago

Its supposed to be constantly 'Mainnet'?(even when the user is on Goerli)

[NetworkType.L1]: { label: 'Ethereum Mainnet', icon: { path: 'tokens/ETH' } },

yairans-starkware commented 2 years ago

@galuzan-starkware in farther PR it was changed to 'Ethereum'

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.9.0-dev.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: