feat(3127762574): Inject env vars dynamically for Docker container

starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.

https://starkgate.starknet.io

Apache License 2.0

148 stars 84 forks source link

Closed danielgluskin-starkware closed 2 years ago

danielgluskin-starkware commented 2 years ago

Use dynamic images - build once for a version - regardless of the env. Inject the env var dynamically on container start.

[X] Changes have been done against dev branch, and PR does not conflict.
[ ] Manually tests of the main Application flows are done and passed.
[ ] New unit / functional tests have been added (whenever applicable).
[X] Automation tests are passing in local environment.
[ ] Docs have been updated (whenever relevant).
[X] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

netlify[bot] commented 2 years ago

Name	Link
Latest commit	9e4edb2bb9bd1bab6373e6d5576523d7a6c1f62e
Latest deploy log	https://app.netlify.com/sites/goerli-starkgate/deploys/6315ed08113fbf00094020dd
Deploy Preview	https://deploy-preview-289--goerli-starkgate.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Name	Link
Latest commit	9e4edb2bb9bd1bab6373e6d5576523d7a6c1f62e
Latest deploy log	https://app.netlify.com/sites/integration-starkgate/deploys/6315ed08c6d89f0008d077ae
Deploy Preview	https://deploy-preview-289--integration-starkgate.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

danielgluskin-starkware commented 2 years ago

@danielgluskin-starkware in general LGTM. One comment before we can merge: create scripts dir and move .sh files under it.

updated

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.9.0-dev.19 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 1 year ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 1 year ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: